status: Stop using .panel-status-button

This used to be the style-class for status icons (i.e. icon-only
top bar items). It got unused a while ago when the class used
by status icons stopped using it - except for the keyboard indicator,
which set the class manually to appear as status icon despite not
being a real icon.
Now that the button highlight is provided by the .panel-button class
on a parent, the obsolete class results in a double border on the
keyboard indicator when active - just drop it from there as well
to fix.

diff --git a/data/theme/_common.scss b/data/theme/_common.scss
index c5de4e3fb1cc01f4d95ef037630dae10ca6ff71e..f56e272088cbee09eda32ec0004fc55dea7e3995 100644 (file)
--- a/data/theme/_common.scss
+++ b/data/theme/_common.scss
@@ -684,14 +684,6 @@ StScrollBar {
     }
   }
   
-  .panel-status-button {
-  
-    &:active, &:overview, &:focus, &:checked {
-      border-color: lighten($selected_bg_color,5%);
-      border-bottom-width: 2px;
-    }
-  }
-  
   .panel-status-indicators-box,
   .panel-status-menu-box {
     spacing: 2px;

diff --git a/data/theme/gnome-shell-high-contrast.css b/data/theme/gnome-shell-high-contrast.css
index 588f79d6ce069b565b8af503566a404540d6a403..48ee64df49853adb45e87926cb4388cd51daa4d5 100644 (file)
--- a/data/theme/gnome-shell-high-contrast.css
+++ b/data/theme/gnome-shell-high-contrast.css
@@ -579,9 +579,6 @@ StScrollBar {
       color: white; }
       .unlock-screen #panel .panel-button:focus, .unlock-screen #panel .panel-button:hover, .unlock-screen #panel .panel-button:active, .login-screen #panel .panel-button:focus, .login-screen #panel .panel-button:hover, .login-screen #panel .panel-button:active, .lock-screen #panel .panel-button:focus, .lock-screen #panel .panel-button:hover, .lock-screen #panel .panel-button:active {
         color: white; }
-  #panel .panel-status-button:active, #panel .panel-status-button:overview, #panel .panel-status-button:focus, #panel .panel-status-button:checked {
-    border-color: #256ab1;
-    border-bottom-width: 2px; }
   #panel .panel-status-indicators-box,
   #panel .panel-status-menu-box {
     spacing: 2px; }

diff --git a/data/theme/gnome-shell.css b/data/theme/gnome-shell.css
index f390028e93e0709b5ff3680cfe50773ccbb616b0..0431e97d003462e6ac1afac02ea9427f4cdce0f6 100644 (file)
--- a/data/theme/gnome-shell.css
+++ b/data/theme/gnome-shell.css
@@ -579,9 +579,6 @@ StScrollBar {
       color: white; }
       .unlock-screen #panel .panel-button:focus, .unlock-screen #panel .panel-button:hover, .unlock-screen #panel .panel-button:active, .login-screen #panel .panel-button:focus, .login-screen #panel .panel-button:hover, .login-screen #panel .panel-button:active, .lock-screen #panel .panel-button:focus, .lock-screen #panel .panel-button:hover, .lock-screen #panel .panel-button:active {
         color: white; }
-  #panel .panel-status-button:active, #panel .panel-status-button:overview, #panel .panel-status-button:focus, #panel .panel-status-button:checked {
-    border-color: #256ab1;
-    border-bottom-width: 2px; }
   #panel .panel-status-indicators-box,
   #panel .panel-status-menu-box {
     spacing: 2px; }

diff --git a/js/ui/status/keyboard.js b/js/ui/status/keyboard.js
index 3595a39d0a8d0aa307d0a5da3686005b63b333b7..e3938d541c5767fa23f638dc44658f4015b4e3c2 100644 (file)
--- a/js/ui/status/keyboard.js
+++ b/js/ui/status/keyboard.js
@@ -589,7 +589,6 @@ const InputSourceIndicator = new Lang.Class({
         this._hbox.add_child(PopupMenu.arrowIcon(St.Side.BOTTOM));
 
         this.actor.add_child(this._hbox);
-        this.actor.add_style_class_name('panel-status-button');
 
         this._propSeparator = new PopupMenu.PopupSeparatorMenuItem();
         this.menu.addMenuItem(this._propSeparator);